-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/battery warning msi laptop #45
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
// publish voice message | ||
if (old_message != message && message != "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have indeed :-)
Can also be part of the callback though AFAIK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. We would want to check whether the percentage has changed rather than the message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there :-)
scripts/services/hero2-demo/hero2-battery-manager-laptop.service
Outdated
Show resolved
Hide resolved
@PetervDooren can you test this and merge it? |
Tested on the robot. After this last commit it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like the launch file rename to battery_manager_hero2.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test before merging
ros::param::get("/robot_location", robot_location); | ||
|
||
ros::Subscriber battery_sub = gn.subscribe("battery", 1, batteryCallback); | ||
speech_pub = gn.advertise<std_msgs::String>("text_to_speech/input", 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This speech publisher goes to the text to speech bridge node. Please either:
- publish directly to the toyota interface (my preference)
- launch the speech bridge along with the battery manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I publish directly to the toyota interface? What is the topic name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be found in the speech bridge https://github.com/tue-robotics/hero_bridge/blob/master/src/speech_node/speech.py
} | ||
|
||
// publish voice message | ||
if (old_message != message && message != "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. We would want to check whether the percentage has changed rather than the message
@KevinDang74 Installation process on hero2 is taken care of. I still have some changes I would like to see so I'm passing it back to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in this package. As it is only used on the robot and not in simulation
1b3ad51
to
d807f5f
Compare
No description provided.